Skip to content

Demo of new preferences package #38435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talldan wants to merge 1 commit into from
Closed

Demo of new preferences package #38435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/reference-guides/data/data-core-edit-post.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,11 @@ _Returns_

### switchEditorMode

Undocumented declaration.
Triggers an action used to switch editor mode.

_Parameters_

- _mode_ `string`: The editor mode.

### toggleEditorPanelEnabled

Expand Down
4 changes: 4 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/base-styles/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ $z-layers: (
// ...Except for popovers immediately beneath wp-admin menu on large breakpoints
".components-popover.block-editor-inserter__popover": 99999,
".components-popover.table-of-contents__popover": 99998,
".components-popover.edit-post-more-menu__content": 99998,
".components-popover.edit-site-more-menu__content": 99998,
".components-popover.interface-more-menu__content": 99998,
".components-popover.block-editor-rich-text__inline-format-toolbar": 99998,
Expand Down
52 changes: 4 additions & 48 deletions packages/data/src/plugins/persistence/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,53 +296,6 @@ export function migrateFeaturePreferencesToPreferencesStore(
}
}

/**
* Move the 'features' object in local storage from the sourceStoreName to the
* interface store.
*
* @param {Object} persistence The persistence interface.
* @param {string} sourceStoreName The name of the store that has persisted
* preferences to migrate to the interface
* package.
*/
export function migrateFeaturePreferencesToInterfaceStore(
persistence,
sourceStoreName
) {
const interfaceStoreName = 'core/interface';
const state = persistence.get();
const sourcePreferences = state[ sourceStoreName ]?.preferences;
const sourceFeatures = sourcePreferences?.features;

if ( sourceFeatures ) {
const targetFeatures =
state[ interfaceStoreName ]?.preferences?.features;

// Avoid migrating features again if they've previously been migrated.
if ( ! targetFeatures?.[ sourceStoreName ] ) {
// Set the feature values in the interface store, the features
// object is keyed by 'scope', which matches the store name for
// the source.
persistence.set( interfaceStoreName, {
preferences: {
features: {
...targetFeatures,
[ sourceStoreName ]: sourceFeatures,
},
},
} );

// Remove feature preferences from the source.
persistence.set( sourceStoreName, {
preferences: {
...sourcePreferences,
features: undefined,
},
} );
}
}
}

/**
* Deprecated: Remove this function and the code in WordPress Core that calls
* it once WordPress 6.0 is released.
Expand All @@ -359,7 +312,10 @@ persistencePlugin.__unstableMigrate = ( pluginOptions ) => {
persistence,
'core/customize-widgets'
);
migrateFeaturePreferencesToInterfaceStore( persistence, 'core/edit-post' );
migrateFeaturePreferencesToPreferencesStore(
persistence,
'core/edit-post'
);
};

export default persistencePlugin;
Loading