Template Editing Mode: Fix horizontal scrollbar #38612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Template Editing Mode
|
Size Change: +1 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Feb 8, 2022
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Nice, thank you! I'm glad we're finding these edgecases as a result of the original PR.
Contributor
|
Screenshot of the fix: I wanted to note, though, this fixes it for the edit-post package. But shouldn't we fix it also for the edit-site package? I know that doesn't yet have the dark frame, and the fact that the CSS is split between the two makes it hard to avoid drift. But it's very likely that gray frame will exist there in some form in the future, might as well prepare for it? |
Member
Author
|
Thank you for testing, @jasmussen. The issue currently only affects the post editor. I can see that the site editor still has reset and blanket rules: gutenberg/packages/edit-site/src/style.scss Lines 34 to 38 in 271703c |
jameskoster
approved these changes
Feb 8, 2022
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Thanks for the fix, it's working well :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes horizontal scrollbar inside template editing mode. This regression was introduced after removing blanked CSS rule for box-sizing (#37902).
Resolves #38374.
Testing Instructions
Screenshots
Types of changes
Bugfix/Regression
Checklist:
*.native.jsfiles for terms that need renaming or removal).