Skip to content

Navigation: Select dropdown encapsulation and further consolidation. #38627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 11 commits into from
Feb 14, 2022
Merged

Navigation: Select dropdown encapsulation and further consolidation. #38627

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d3f9ee9
Encapsulate permissions checks
getdave Feb 8, 2022
acdb553
Utilise primary component inside placeholder
getdave Feb 8, 2022
11f6d58
Inline existing menus options
getdave Feb 9, 2022
9cf6f34
Account for create vs switch in aria label depending on context
getdave Feb 9, 2022
c5c3377
Remove explicit truthy in prop
getdave Feb 9, 2022
eda20d5
Rename vars to include "Menu"
getdave Feb 10, 2022
d2975e8
Improve prop naming for clarity
getdave Feb 10, 2022
7e2c158
Improve conditionals around display of management options
getdave Feb 11, 2022
a086afe
Wait for the custom link block
getdave Feb 11, 2022
7edc097
Wait for the menuItems response
getdave Feb 14, 2022
bdb24ad
Improve conditional
getdave Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wait for the custom link block
  • Loading branch information
@getdave
getdave committed Feb 11, 2022
commit a086afe39a63ce52e5e538a088f5de7c6821ec94
5 changes: 5 additions & 0 deletions packages/e2e-tests/specs/editor/blocks/navigation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ async function selectClassicMenu( optionText ) {
`//*[contains(@class, 'components-menu-item__item')][ text()="${ optionText }" ]`
);
await theOption.click();

const navLinkBlockSelector =
'[aria-label="Editor content"][role="region"] [aria-label="Block: Custom Link"]';

await page.waitForSelector( navLinkBlockSelector );
}

const PLACEHOLDER_ACTIONS_CLASS = 'wp-block-navigation-placeholder__actions';
Expand Down