-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Refactor classic menu conversion process #38858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b0a7d1d
Refactor hook to single async function
getdave 124e244
Adjust UI state vars to account for conversion process state
getdave ffa8a7e
Unify menu ref update process
getdave 34974ac
Remove superceeded hook
getdave c8a8e1c
Refactor conversion state to enum
getdave 8161482
Add initial error handling for conversion process
getdave 651ed4c
i18n of classic menu fetch error
getdave 27d0a94
Handle more creation errors
getdave 6fad279
Manually hoist var
getdave 04bdbc2
Add accessible menu import announcements
getdave 35cbf10
Refactor to remove useReducer in favour of simple useState
getdave 864a469
Fix bug where constants were accidentally assigned to constants
getdave 987c38f
Simplify menu selector props
getdave 31ccf02
Improve error handling
getdave 5ae5df7
Use constants over comparisons for statuses
getdave bf69385
Extract common function for handling selecting a Navigation
getdave ef9b3d7
Optimise handler
getdave ca5eeb5
Remove unwanted conditional operator
getdave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add initial error handling for conversion process
- Loading branch information
commit 8161482568ffaa0017a17d81711983c9e5debd6d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.