Borders: Add BorderBoxControl component #38876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Feature] UI Components
aaronrobertshaw
requested review from
ajitbohra,
mkaz and
ryanwelcher
as code owners
7 tasks
|
Size Change: +1.54 kB (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
7 tasks
mirka
reviewed
Feb 28, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
This is a very cool component! While there is a good amount of complexity being handled on the logic side, I was pleasantly surprised at how clean the UI implementation itself was. I don't know why but before reading the code I totally overcomplicated the visualizer implementation in my head — but it's actually just a positioned div! 🤦😆 Elegant use of grid on top of it too!
packages/components/src/border-box-control/border-box-control-split-controls/component.tsx
Show resolved
Hide resolved
packages/components/src/border-box-control/border-box-control-visualizer/component.tsx
Outdated
Show resolved
Hide resolved
ciampo
reviewed
Mar 1, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
As others have also commented, this is great work!
I'm just leaving here some high-level feedback that I also gave on the sister PR #37769:
- using
ForwardedReftype instead ofRef - wrapping all styles that affect right/left in the
rtl()utility function - trying to replace as many hardcoded DOM structures as possible with the Styled component selector (example)
- Investigate building the UI with the
FlexandGridcomponents when possible over CSS styles (this is more of a preference / exploration, definitely not blocking — I think it's interesting to explore the composability of our components and discover any potential limitations!) - avoid using inline styles where possible
Thank you again for your work on this one!
packages/components/src/border-box-control/border-box-control-visualizer/component.tsx
Outdated
Show resolved
Hide resolved
aaronrobertshaw
force-pushed
the
try/combined-border-controls
branch
from
3dda204 to
b17da1a
Compare
8 tasks
aaronrobertshaw
force-pushed
the
add/border-box-control
branch
2 times, most recently
from
08acd46 to
310cb96
Compare
7 tasks
mirka
approved these changes
Mar 22, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Awesome work on this complex component! 🚀
aaronrobertshaw
force-pushed
the
add/border-box-control
branch
from
310cb96 to
31f7bc8
Compare
This provides a component through which you can configure separate borders for individual sides.
- Moves the `getClampedWidthBorderStyle` functionality into the style.ts file - Updates `getShorthandBorderStyle` to accept optional fallback border styles to work around possible override of inherited values.
aaronrobertshaw
force-pushed
the
add/border-box-control
branch
from
31f7bc8 to
1aeb812
Compare
This was referenced Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Description
This PR adds a
BorderBoxControlcomponent that provides a better experience when configuring individual borders for different sides.BorderBoxControlBorderControlto allow the configuration of a single flat border or individual borders for each side.How has this been tested?
Via unit tests;
npm run test-unit packages/components/src/border-box-control/test/index.jsnpm run test-unit packages/components/src/border-box-control/test/utils.jsManually:
npm run storybook:devBorderBoxControlScreenshots
Types of changes
New feature.
Known Issues
Checklist:
*.native.jsfiles for terms that need renaming or removal).