canUser resolver: remove fallback for OPTIONS response headers #38881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -39 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
Contributor
|
This is awesome! |
cbravobernal
added
the
[Type] Code Quality
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #38051,
apiFetch( { method: 'OPTIONS', parse: false } ), always returns aResponseobject with aHeaderssubobject, never a plain JS object, even for preloaded responses. Therefore thecanUserresolver can callresponse.headers.get( 'allow' )without any checks or fallback for plain objects.I also had to update unit tests to mock responses in such a way that
headers.getworks. I usedMapfor mocking that, which is not perfect (the lookup is not case-insensitive for example), but to construct a realHeadersobject I would have to use JSDOM environment for the test.