Update drag gesture of InputControl-based controls with axial constraint#38968
Merged
Update drag gesture of InputControl-based controls with axial constraint#38968
InputControl-based controls with axial constraint#38968Conversation
mirka
reviewed
Feb 22, 2022
Member
mirka
left a comment
There was a problem hiding this comment.
Great fix, it's working well for me in all browsers ✨ Once we add a changelog entry, I think the fix part is ready to go.
22641ab to
9b78e98
Compare
9b78e98 to
11c8c97
Compare
Contributor
Author
|
@mirka, Thanks for testing and reviewing. I think this should be good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is largely intended as an enhancement though it is also a bug fix (for some browsers). As a bug fix, in Safari and Firefox, it allows drag gestures to highlight text as expected.
Testing Instructions
NumberControlorUnitControlScreenshots
Before: Unexpected interference with input value selection (Firefox and Safari)
before-input-control-axial.mp4
After: Input value selection works as expected
after-input-control-axial.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).