Skip to content

Core Data: Resolve getCurrentUser on API error #38989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mamaduka wants to merge 1 commit into from
Closed

Core Data: Resolve getCurrentUser on API error #38989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/core-data/src/resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ export const getAuthors = ( query ) => async ( { dispatch } ) => {
* Requests the current user from the REST API.
*/
export const getCurrentUser = () => async ( { dispatch } ) => {
const currentUser = await apiFetch( { path: '/wp/v2/users/me' } );
dispatch.receiveCurrentUser( currentUser );
try {
const currentUser = await apiFetch( { path: '/wp/v2/users/me' } );
dispatch.receiveCurrentUser( currentUser );
} catch ( error ) {
// Catching the error ensures the resolver is marked as resolved.
}
};

/**
Expand Down
12 changes: 12 additions & 0 deletions packages/core-data/src/test/resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,4 +454,16 @@ describe( 'getCurrentUser', () => {
SUCCESSFUL_RESPONSE
);
} );

it( 'does nothing when there is an API error', async () => {
const dispatch = Object.assign( jest.fn(), {
receiveCurrentUser: jest.fn(),
} );

triggerFetch.mockRejectedValue( { status: 401 } );

await getCurrentUser()( { dispatch } );

expect( dispatch.receiveCurrentUser ).not.toHaveBeenCalled();
} );
} );