Skip to content

TypeScript signatures for core-data selectors #39025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamziel wants to merge 36 commits into from
Closed

TypeScript signatures for core-data selectors #39025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8601b2f
Propose type signatures for core-data selectors
adamziel Feb 23, 2022
00a0750
Exploring different ways of accessing entity record types
adamziel Feb 23, 2022
051b8d3
Simplify the types
adamziel Feb 23, 2022
1c92210
More succinct EntityTypeUnion declaratio
adamziel Feb 23, 2022
305e344
Yes! Correct type inference in getEntityRecord
adamziel Feb 23, 2022
c01f310
Simplify Name handling
adamziel Feb 23, 2022
2e10458
remove extends Object
adamziel Feb 23, 2022
5830578
Entity type-based inference
adamziel Feb 24, 2022
ce8e160
Isolate the getEntityRecord selector
adamziel Feb 24, 2022
69f4188
Revert to using only Partial<> and not Pick<>
adamziel Mar 3, 2022
6779217
Remove dev artifacts and ignore ts error related to importing @wordpr…
adamziel Mar 3, 2022
0f72bbb
Remove unused import
adamziel Mar 3, 2022
abc8dc3
Lint
adamziel Mar 3, 2022
f2deedf
Remove commented out test examples from selectors-ts.ts
adamziel Mar 3, 2022
0f680d3
Move getEntityRecord type definition to types/selectors.ts, use via @…
adamziel Mar 3, 2022
3d84668
Add docstrings to EntityQuery and EntityFromConfig
adamziel Mar 3, 2022
09e6c20
Remove the unnecessary trailing comma
adamziel Mar 3, 2022
e437266
Restore the js version of get-normalized-comma-separable.js
adamziel Mar 3, 2022
42fca22
Add type for getEditedEntityRecord
adamziel Mar 3, 2022
0ecb36f
Remove Query from getEditedEntityRecord
adamziel Mar 3, 2022
15893ef
Add getRawEntityRecord type
adamziel Mar 3, 2022
550564e
Wrap @type getEditedEntityRecord in braces
adamziel Mar 3, 2022
57df3db
Reduce the public API surface area of the types to just the selectors…
adamziel Mar 4, 2022
9c1249c
Restore the trunk version of selectors.js
adamziel Mar 4, 2022
05a26c4
Make entity records aware of their default contexts
adamziel Mar 4, 2022
70a8d4e
Use the same DefaultContextOf type for both by-record lookups and kin…
adamziel Mar 4, 2022
7161a4c
Add types for all core-data selectors
adamziel Mar 4, 2022
d6f2e24
Turn EntityQuery into a private type
adamziel Mar 4, 2022
79dc553
Adjust import paths
adamziel Mar 7, 2022
8964cb0
Only return a partial object when _fields were passed
adamziel Mar 9, 2022
27db5ca
Use EntityQuery type in getEntityRecord type signature
adamziel Mar 9, 2022
97f845e
Use trunk's version of selectors.js
adamziel Mar 14, 2022
8d90602
Use a language consistent with the latest version of core-data
adamziel Mar 14, 2022
f641dd7
Remove the EntityDeclaration type
adamziel Mar 14, 2022
1583b8a
Remove the unused EntityInterface from entity-types/entities.ts
adamziel Mar 14, 2022
2ffbf78
Restore missing export keywords
adamziel Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
331 changes: 0 additions & 331 deletions packages/core-data/src/entities.js
View file
Open in desktop

This file was deleted.

Loading