Expose plugin area to site editor's List page #39078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
zaguiini
commented
Feb 24, 2022
kevin940726
approved these changes
Feb 25, 2022
zaguiini
force-pushed
the
add/plugin-area-to-site-editor-list-page
branch
from
0f2878e to
bf5033d
Compare
zaguiini
changed the title
jeyip
reviewed
Feb 25, 2022
Contributor
There was a problem hiding this comment.
Testing
This tests well 👍 I followed the testing instructions and ran the following in the devtools panel.
var el = wp.element.createElement;
var Fill = wp.components.Fill;
var registerPlugin = wp.plugins.registerPlugin;
registerPlugin( 'test', {
render: function() {
return el(
Fill,
{ name: '__experimentalMainDashboardButton' },
el('span', {}, 'hello, world')
);
}
} );
Requirements
-
hello, worldmessage appears at the top instead of the < Dashboard button on both the editor page and the list page
Browsers
- Firefox
- Chrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds parity between the editor and the list page inside the site editor regarding the
PluginArea. Without it, it's not possible to fill the provided slots by using theregisterPluginAPI.The absence of the plugin area caused a bug in Calypso where the slots were only being filled in the editor's navigation drawer.
Testing Instructions
Open the site editor and run this code in the DevTools after the page is loaded:
Click the W button and check that
hello, worldmessage appears at the top instead of the< Dashboardbutton on both the editor page and the list by clicking onTemplatesorTemplate Partsinside the navigation drawer.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).