[Mobile] UnitControl: align component with web counterpart
#39218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Contributor
Author
|
Closing this PR for lack of activity. @geriux , feel free to re-open / open a new PR in case |
johnbillion
deleted the
feat/components-native-unit-control-unit-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
UnitControlnative component's logic is currently out-of-date compared to the web counterparts and the docs.In particular:
valueonly contains the numeric quantity, and the the unit should be passed via theunitpropcurrentInput,initialPosition)falsefor theunitspropFor reference:
unitprop is marked as deprecated and should be not used anymorevalueprop is expected to contain both the quantity and the unit (e.g'34%')unitsprop is expected to be only an array of unit objects (and not a boolean)units = {false}, a better approach could be to use thedisableUnitspropcc @geriux
As a follow-up, once the native
UnitControlalso deprecates theunitprop, we should update all the instances in which native consumers of this component use theunitprop — as a reference, this was tracked in #39503 for the web version of the componentTesting Instructions
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).