[RNMobile] Use internal initializeEditor for integration tests
#39224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
8 tasks
Contributor
|
Removing myself from the reviewers list for a bit since I won't have the chance to add a review in the next couple of days or so. |
ttahmouch
reviewed
Mar 4, 2022
Contributor
ttahmouch
left a comment
ttahmouch
left a comment
There was a problem hiding this comment.
Since this doesn't appear to be a large change, I'll try to confirm shortly that all the tests pass in your branch locally to confirm that this doesn't break the downstream tests.
| // for this reason it's imported with path access. | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| import Editor from '@wordpress/edit-post/src/editor'; | ||
| import { initializeEditor as internalInitializeEditor } from '@wordpress/edit-post'; |
Contributor
There was a problem hiding this comment.
Proxying through the internal initializeEditor makes a lot of sense to me because of the introduction of the dispatching to the preferences store.
ttahmouch
approved these changes
Mar 7, 2022
fluiddot
deleted the
rnmobile/update/integration-tests-internal-initialize-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The helper function
initializeEditor, which is used for initializing the editor in integration tests, gets the Editor component directly from the@wordpress/edit-postpackage, instead of using theinitializeEditorfunction provided by the same package (reference). I can't recall why we decided to initialize the editor this way, probably was related to the fact that theinitializeEditorfunction just returns the editor element, so we could skip it. However, with the changes that will be introduced in #39180, now we'll have some logic that is required for initializing the editor in that function hence, we should use it for getting the Editor component in integration tests.Testing Instructions
npm run native testand observe that all test passes.Unit Tests / MobilePR check passes.Screenshots
N/A
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).