Skip to content

[RNMobile] Add featured image settings to the Latest Posts block #39257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SiobhyB merged 23 commits into from
Apr 27, 2022
Merged

[RNMobile] Add featured image settings to the Latest Posts block #39257

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
447f2a8
Add 'display featured image' toggle to settings
SiobhyB Mar 7, 2022
49a5824
Add 'link to featured image' toggle to settings
SiobhyB Mar 7, 2022
e49d8ef
Add alignment control to featured image settings
SiobhyB Mar 11, 2022
0ad7afe
Style BlockAlignmentControl within BottomSheet
SiobhyB Mar 11, 2022
61d12b7
Update new BottomSheet's label
SiobhyB Mar 11, 2022
30c62ac
Update CHANGELOG
SiobhyB Mar 11, 2022
9278d5f
Merge branch 'trunk' into rnmobile/update/latest-posts-featured-settings
SiobhyB Mar 11, 2022
466c655
Merge branch 'trunk' into rnmobile/update/latest-posts-featured-settings
SiobhyB Mar 21, 2022
ae2d3ae
Remove redundant new line (added by mistake)
SiobhyB Mar 21, 2022
9d99ffa
Revert BlockAlignmentControl implementation
SiobhyB Mar 24, 2022
f81bb40
Add alignment options via BottomSheetSelectControl
SiobhyB Mar 24, 2022
28235ad
Add separator between settings
SiobhyB Mar 24, 2022
21e52a1
Move BLOCK_ALIGNMENTS_CONTROLS to constants file
SiobhyB Mar 24, 2022
b5dbeec
Merge branch 'trunk' into rnmobile/update/latest-posts-featured-settings
SiobhyB Mar 25, 2022
0fe02e6
Refactor to make use of 'BlockAlignmentControl'
SiobhyB Apr 22, 2022
19b0e21
Create native version of 'ui.js'
SiobhyB Apr 22, 2022
c0799d1
Merge branch 'trunk' into rnmobile/update/latest-posts-featured-settings
SiobhyB Apr 22, 2022
40765b4
Remove native-specific code from web-only file
SiobhyB Apr 22, 2022
ec59670
Style BlockAlignmentControl within BottomSheet
SiobhyB Apr 22, 2022
dac3698
Move constants to dedicated file
SiobhyB Apr 22, 2022
9fb7b38
Remove unnecessary code in web-only file
SiobhyB Apr 22, 2022
abf44c8
Only pass props when components use them
SiobhyB Apr 22, 2022
30db2b0
Merge branch 'trunk' into rnmobile/update/latest-posts-featured-settings
SiobhyB Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update new BottomSheet's label
  • Loading branch information
@SiobhyB
SiobhyB committed Mar 11, 2022
commit 61d12b7c1bbe96f49f5f8c391c1c61760b6b3c01
7 changes: 7 additions & 0 deletions packages/components/src/dropdown-menu/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ function DropdownMenu( {
toggleProps
);

const isSelected = flatMap( controlSets, ( controlSet ) =>
controlSet.map(
( control ) => control.isActive && control.title
)
);

const toolbarButton = () => (
<Button
{ ...mergedToggleProps }
Expand Down Expand Up @@ -117,6 +123,7 @@ function DropdownMenu( {
aria-expanded={ isOpen }
label={ label }
leftAlign
value={ isSelected }
>
<Icon icon={ chevronRight }></Icon>
</BottomSheet.Cell>
Expand Down