Image block: Add additional selector to account for the move of is-style classes #39295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the deprecated align div in e04ec56
glendaviesnz
added
[Type] Bug
|
Size Change: +19 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Contributor
|
This tests well for me! |
chad1008
approved these changes
Mar 8, 2022
chad1008
pushed a commit
that referenced
this pull request
Mar 8, 2022
…rom the deprecated align div in e04ec56 (#39295) Co-authored-by: Glen Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds an additional selector for the Image blocks core
is-style-roundedstyle. Fixes: #39242Why?
In #38657 the additional wrapper that was added to allow for image alignment was removed and all of the classes were moved to the
figureelement. For non theme.json themes the wrapperdivwas added back in the frontend, but theis-style-classes are not moved to this div, so the styling is lost on the frontend.How?
The addition of
.wp-block-image .is-style-rounded imgas well as.wp-block-image.is-style-rounded imgmakes sure that both instances are accounted for.N.B. - this only fixes the image
is-style-roundedcore style. Any image styles set within a theme that rely on the style class being on the same element as.wp-block-imagewill still be broken.Testing Instructions
Screenshots
Before:
image-align-before.mp4
After:
imag-align-after.mp4