Add @testing-library/user-event to the project
#39360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +151 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ciampo
added
[Package] Components
ciampo
force-pushed
the
feat/testing-library-user-event
branch
from
784d862 to
9f5d486
Compare
8 tasks
ciampo
commented
Mar 10, 2022
| "@testing-library/jest-dom": "5.16.1", | ||
| "@testing-library/react": "11.2.2", | ||
| "@testing-library/react-native": "9.0.0", | ||
| "@testing-library/user-event": "^14.0.0-beta.13", |
Contributor
Author
There was a problem hiding this comment.
This the latest available version, and is the recommended one over the previously stable version (13.5.0)
From the official docs:
These docs describe
[email protected]. This is still a pre-release and might be subject to breaking changes if they should be deemed necessary in the light of feedback we receive for this version. All planned breaking changes are already implemented though.
If you are starting or actively working on a project, we recommend to use this pre-release, as it includes important bug fixes and new features.
Member
|
Do you plan to include some best practices for testing components with React Testing Library? that links to: Maybe it's a good opportunity to add a section for testing interaction in the component? |
Contributor
Author
Good idea, I'll look into it and likely push and update to this PR. |
ciampo
force-pushed
the
feat/testing-library-user-event
branch
from
7eb166e to
bb75f74
Compare
Contributor
Author
|
Hey @gziolo , I've added some docs as you suggested, let me know if you have any feedback! |
mirka
reviewed
Mar 14, 2022
ciampo
commented
Mar 14, 2022
ciampo
commented
Mar 14, 2022
Co-authored-by: Lena Morita <[email protected]>
ciampo
force-pushed
the
feat/testing-library-user-event
branch
from
eddb9de to
8afd1d0
Compare
stokesman
reviewed
Mar 14, 2022
Contributor
stokesman
left a comment
stokesman
left a comment
There was a problem hiding this comment.
Looks good on the whole. I found a few small things to note.
Co-authored-by: Mitchell Austin <[email protected]>
Contributor
Author
Thank you @stokesman ! I applied all of your suggestions as they made sense to me. |
Member
|
This is great, thank you for making the extra effort to land it in a separate PR with all the documentation additions included. Impressive work 💯 |
Contributor
|
+1, thanks @ciampo, the added documentation in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As per #39148 (comment), Add
@testing-library/user-eventto the project and use it inUnitControl's unit tests to showcase how it would be used in the codebase.Why?
The
user-eventlibrary is a companion to@testing-librarythat simulates user interactions by dispatching the events that would happen if the interaction took place in a browser.Compared to the built-in
fireEventutility, theuser-eventlibrary allows a developer to write tests like they would happen if a user interacted with the document. This switch in paradigm moves away from testing implementation details (e.g. firing the exact HTML event), and makes tests written withuser-eventmore meaningful.How?
package.jsonandpackage-lock.jsonUnitControl's unit tests to showcase how to use the newly introduced APIsUnitControlandInputControl'skeydownlisteners to stop using the old and deprecatedevent.keyCode(which is not supported anymore by@testing-library/user-event), use the standardevent.keyproperty insteadTesting Instructions
UnitControl's unit tests are still passing