Fix experimental full site editing blocks not being registered #39415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
8 tasks
michalczaplinski
approved these changes
Mar 14, 2022
Contributor
michalczaplinski
left a comment
michalczaplinski
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you @talldan ! 🙏
Contributor
|
Should we add some (basic) e2e test coverage for the new (experimental) Comment blocks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a an issue introduced in #39180 - experimental full site editing blocks were not being registered.
Props to @michalczaplinski for noticing this and finding the PR that introduced the bug.
Why?
In #39180, some block settings were moved to a new file the wordpress-5.9 folder.
The issue is that this file wasn't being loaded, so the editor settings (which included
__unstableEnableFullSiteEditingBlocks) were not being applied.How?
Added a new line to the
load.phpto require the file.Testing Instructions
comments-query-loopblockExpected: The block should be available and can be added.