Skip to content

Spacer block: stop using UnitControl's deprecated unit prop #39513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 4 commits into from
Mar 18, 2022
Merged

Spacer block: stop using UnitControl's deprecated unit prop #39513

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32ff0d8
Memoize
ciampo Mar 16, 2022
1fdad2c
Remove `temporaryInput`
ciampo Mar 17, 2022
fd18928
Add `isResetValueOnUnitChange` prop back
ciampo Mar 18, 2022
1c22f97
Do not memoize value computation
ciampo Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add isResetValueOnUnitChange prop back
  • Loading branch information
@ciampo
ciampo committed Mar 18, 2022
commit fd18928678a55b369dc2ec8c8e07dea646293fde
1 change: 1 addition & 0 deletions packages/block-library/src/spacer/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ function DimensionInput( { label, onChange, isResizing, value = '' } ) {
<BaseControl label={ label } id={ inputId }>
<UnitControl
id={ inputId }
isResetValueOnUnitChange
min={ 0 }
max={ MAX_SPACER_SIZE }
onChange={ handleOnChange }
Expand Down