Skip to content

Fix UnitControl resets unit when value is cleared #39531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 4 commits into from
Mar 21, 2022
Merged

Fix UnitControl resets unit when value is cleared #39531

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bba5bf
Avoid setting unit from effect hook if parsed to `undefined`
stokesman Mar 17, 2022
4bfdd1c
Add unit test
stokesman Mar 21, 2022
e2e5a46
Add changelog entry
stokesman Mar 21, 2022
ba85ce3
Remove duplicated `Bug Fix` section in the CHANGELOG
ciampo Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove duplicated Bug Fix section in the CHANGELOG
  • Loading branch information
@ciampo
ciampo committed Mar 21, 2022
commit ba85ce3331d4f76f0f749a4e18b9734ab2efe990
5 changes: 1 addition & 4 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

## Unreleased

### Bug Fix

- Fix `UnitControl`’s reset of unit when the quantity value is cleared. ([#39531](https://github.com/WordPress/gutenberg/pull/39531/)).

### Enhancements

- `BaseControl`: Add `__nextHasNoMarginBottom` prop for opting into the new margin-free styles ([#39325](https://github.com/WordPress/gutenberg/pull/39325)).
Expand All @@ -23,6 +19,7 @@
### Bug Fix

- `NumberControl`: commit (and constrain) value on `blur` event ([#39186](https://github.com/WordPress/gutenberg/pull/39186)).
- Fix `UnitControl`'s reset of unit when the quantity value is cleared. ([#39531](https://github.com/WordPress/gutenberg/pull/39531/)).

## 19.6.0 (2022-03-11)

Expand Down