Disabled: Add documentation for 'Disabled.Context' #39627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Developer Documentation
ciampo
reviewed
Mar 22, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Since context is a standard React API (and there's even a link to the docs), I wonder if we should just keep the hook version of the example and remove the "legacy" version.
Member
Author
|
@ciampo I was thinking the same. The new React docs also recommend using the Happy to update the readme if you're okay with that. |
Contributor
Let's do that, thank you! |
Member
Author
|
Updated. |
ciampo
reviewed
Mar 22, 2022
ciampo
reviewed
Mar 22, 2022
Co-authored-by: Marco Ciampini <[email protected]>
ciampo
approved these changes
Mar 23, 2022
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thank you for the patience in addressing the feedback! I really appreciate your help in contributing to the components package
Member
Author
|
Thanks for the reviews, @ciampo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR adds documentation for
Disabled.Context, introduced in #31134.Why?
Reading context with
useContextshould be preferred when possible.How?
PR updates documentation and adds notes about the preferred method.