ColorPalette: Add SlotFillProvider to story to correct tooltip positioning #39674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Mar 23, 2022
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
Worked as advertised for me
Contributor
Author
|
Thanks for the review @glendaviesnz 👍 Given @mirka has already seen this approach as part of #37769 where we encountered this problem and the solution there was approved, I'll merge this now. I also intend to create another PR updating the components package docs to warn of this tooltip issue and provide code examples for consumers outside of our block/site editors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The positioning of tooltips for the
ColorPalettestorybook example are misaligned. This PR corrects this and brings their positioning more inline with what is seen when theColorPaletteis used in the editor.Why?
The current story on
trunkonly renders theColorPalettecomponent directly. This means that the story doesn't have a slot fill provider allowing tooltips to be rendered in their correct positions.How?
In the
ColorPalettestorybook example, this PR wraps the component in a SlotFill provider and includes thePopover.Slotas a sibling.Testing Instructions
trunkand fire up the storybook, navigating to theColorPalettecomponentColorPalette. The tooltips should now be positioned better.Screenshots or screencast