Skip to content

[RNMobile] Prevent draggable gesture when any text input is focused #39890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluiddot merged 1 commit into from
Mar 31, 2022
Merged

[RNMobile] Prevent draggable gesture when any text input is focused #39890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions packages/components/src/draggable/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
* External dependencies
*/
import { Gesture, GestureDetector } from 'react-native-gesture-handler';
import Animated, { useSharedValue } from 'react-native-reanimated';
import Animated, { useSharedValue, runOnJS } from 'react-native-reanimated';
import TextInputState from 'react-native/Libraries/Components/TextInput/TextInputState';

/**
* WordPress dependencies
Expand Down Expand Up @@ -33,10 +34,24 @@ export default function Draggable( {
wrapperAnimatedStyles,
} ) {
const isDragging = useSharedValue( false );
const isAnyTextInputFocused = useSharedValue( false );

const checkTextInputFocus = () => {
isAnyTextInputFocused.value =
TextInputState.currentlyFocusedInput() !== null;
};

const longPressGesture = Gesture.LongPress()
.onBegin( () => {
'worklet';
runOnJS( checkTextInputFocus )();
} )
.onStart( ( ev ) => {
'worklet';
if ( isAnyTextInputFocused.value ) {
return;
}

isDragging.value = true;

if ( onDragStart ) {
Expand All @@ -45,6 +60,10 @@ export default function Draggable( {
} )
.onEnd( () => {
'worklet';
if ( isAnyTextInputFocused.value ) {
return;
}

isDragging.value = false;
if ( onDragEnd ) {
onDragEnd();
Expand All @@ -60,7 +79,7 @@ export default function Draggable( {
'worklet';
if ( isDragging.value ) {
state.activate();
} else if ( Platform.isIOS ) {
} else if ( Platform.isIOS || isAnyTextInputFocused.value ) {
state.fail();
}
} )
Expand Down