Add duotone to placeholders for site logo and featured image #40085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Enhancement
Contributor
|
Thank you for the PR! I can't get it to work, what am I doing wrong? |
Contributor
Author
|
Ah, the featured image has different markup and class names in the different editors :sigh:. I will submit a fix soon. |
jasmussen
approved these changes
Apr 6, 2022
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Nice.
Gif showing it colorizes the placeholder:
This was referenced Apr 14, 2022
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make sure the duotone is visible on placeholders for featured image and site logo.
Closes #40061
Why?
To show that a duotone is applied to the block.
How?
By adding additional CSS selectors to
"__experimentalDuotone"in block-json.Testing Instructions
Screenshots or screencast
Featured image on top,
site logo,
selected site logo