Try: Summary panel excerpt max-height. #40090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Contributor
Maybe we can explore this separately? Once we remove the dedicated Excerpt panel we'll probably need to think about other formatting like making text bold or adding links. |
jameskoster
approved these changes
Apr 6, 2022
ntsekouras
added a commit
that referenced
this pull request
Apr 7, 2022
This reverts commit e05bc19.
ntsekouras
added a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #39973. Applies a max-height to the excerpt. Before:
After:
A thought occurs that maybe the excerpt shouldn't employ the
ptag, but rather adivperhaps? Right now it's treated as a multiline paragraph.Testing Instructions
Try adding a lot of text in the excerpt panel.