Skip to content

[Multi-selection]: Copy/cut partial selected blocks #40098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 9 commits into from
Apr 13, 2022
Merged

[Multi-selection]: Copy/cut partial selected blocks #40098

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e7b296
[Multi-selection]: Copy/cut partial selected blocks
ntsekouras Apr 6, 2022
6d50760
handle `copy` button in block actions
ntsekouras Apr 6, 2022
1c3c8a1
merge blocks on cut
ntsekouras Apr 7, 2022
b8de1d6
partial copy from block actions only when is mergeable
ntsekouras Apr 7, 2022
b035115
update selector
ntsekouras Apr 7, 2022
d2bacd5
revert partial selection copy in block actions menu item
ntsekouras Apr 11, 2022
e8b0901
add jsdoc for mapRichTextSettings util
ntsekouras Apr 13, 2022
0d20c29
update tests
ntsekouras Apr 13, 2022
65d89b4
add new e2e tests + pressKeyTimes playwright util
ntsekouras Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update tests
  • Loading branch information
@ntsekouras
ntsekouras committed Apr 13, 2022
commit 0d20c2963e4a38c9d0398565e90a010fb5476556
7 changes: 0 additions & 7 deletions ...ots/Copy-cut-paste-of-whole-blocks-should-copy-and-paste-individual-blocks-1-chromium.txt
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions ...ots/Copy-cut-paste-of-whole-blocks-should-copy-and-paste-individual-blocks-2-chromium.txt
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ...hots/Copy-cut-paste-of-whole-blocks-should-cut-and-paste-individual-blocks-1-chromium.txt
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions ...hots/Copy-cut-paste-of-whole-blocks-should-cut-and-paste-individual-blocks-2-chromium.txt
View file
Open in desktop

This file was deleted.

43 changes: 9 additions & 34 deletions ...rious/copy-cut-paste-whole-blocks.spec.js → ...ecs/editor/various/copy-cut-paste.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,30 +3,7 @@
*/
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );

test.describe( 'Copy/cut/paste of whole blocks', () => {
test( 'should copy and paste individual blocks', async ( {
page,
pageUtils,
} ) => {
await pageUtils.createNewPost();

await page.click( 'role=button[name="Add default block"i]' );

await page.keyboard.type(
'Here is a unique string so we can test copying.'
);
await page.keyboard.press( 'Enter' );
await page.keyboard.type( '2' );
await page.keyboard.press( 'ArrowUp' );

await pageUtils.pressKeyWithModifier( 'primary', 'c' );
expect( await pageUtils.getEditedPostContent() ).toMatchSnapshot();

await page.keyboard.press( 'ArrowDown' );
await pageUtils.pressKeyWithModifier( 'primary', 'v' );
expect( await pageUtils.getEditedPostContent() ).toMatchSnapshot();
} );

test.describe( 'Copy/cut/paste', () => {
test( 'should copy blocks when non textual elements are focused (image, spacer)', async ( {
page,
pageUtils,
Expand All @@ -47,24 +24,22 @@ test.describe( 'Copy/cut/paste of whole blocks', () => {
expect( await pageUtils.getEditedPostContent() ).toMatchSnapshot();
} );

test( 'should cut and paste individual blocks', async ( {
test( 'should cut and paste individual non textual blocks', async ( {
page,
pageUtils,
} ) => {
await pageUtils.createNewPost();

await page.click( 'role=button[name="Add default block"i]' );

await page.keyboard.type( 'Yet another unique string.' );
await page.keyboard.press( 'Enter' );
await page.keyboard.type( '2' );
await page.keyboard.press( 'ArrowUp' );

await pageUtils.insertBlock( { name: 'core/spacer' } );
// At this point the spacer wrapper should be focused.
await pageUtils.pressKeyWithModifier( 'primary', 'x' );
expect( await pageUtils.getEditedPostContent() ).toMatchSnapshot();

await page.keyboard.press( 'Tab' );
await page.keyboard.press( 'ArrowDown' );
// The block appender is only visible when there's no selection.
await page.evaluate( () => {
window.wp.data.dispatch( 'core/block-editor' ).clearSelectedBlock();
} );
await page.click( 'role=button[name="Add default block"i]' );
await pageUtils.pressKeyWithModifier( 'primary', 'v' );
expect( await pageUtils.getEditedPostContent() ).toMatchSnapshot();
} );
Expand Down
0 ...xtual-element-image-spacer-1-chromium.txt → ...xtual-element-image-spacer-1-chromium.txt
View file
Open in desktop
File renamed without changes.
0 ...s-are-focused-image-spacer-1-chromium.txt → ...s-are-focused-image-spacer-1-chromium.txt
View file
Open in desktop
File renamed without changes.
0 ...s-are-focused-image-spacer-2-chromium.txt → ...s-are-focused-image-spacer-2-chromium.txt
View file
Open in desktop
File renamed without changes.
Empty file added ...napshots/Copy-cut-paste-should-cut-and-paste-individual-non-textual-blocks-1-chromium.txt
View file
Open in desktop
Empty file.
7 changes: 7 additions & 0 deletions ...napshots/Copy-cut-paste-should-cut-and-paste-individual-non-textual-blocks-2-chromium.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

<!-- wp:spacer -->
<div style="height:100px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->
0 ...d-handle-paste-events-once-1-chromium.txt → ...d-handle-paste-events-once-1-chromium.txt
View file
Open in desktop
File renamed without changes.
0 ...input-fields-and-textareas-1-chromium.txt → ...input-fields-and-textareas-1-chromium.txt
View file
Open in desktop
File renamed without changes.
0 ...input-fields-and-textareas-2-chromium.txt → ...input-fields-and-textareas-2-chromium.txt
View file
Open in desktop
File renamed without changes.
0 ...copy-when-text-is-selected-1-chromium.txt → ...copy-when-text-is-selected-1-chromium.txt
View file
Open in desktop
File renamed without changes.
0 ...copy-when-text-is-selected-2-chromium.txt → ...copy-when-text-is-selected-2-chromium.txt
View file
Open in desktop
File renamed without changes.