Skip to content

Editor: Refactor PostFeaturedImage component #40126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 5 commits into from
Apr 29, 2022
Merged

Editor: Refactor PostFeaturedImage component #40126

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0771a1d
Editor: Refactor PostFeaturedImage component
Mamaduka Apr 6, 2022
cf45004
Fix error state
Mamaduka Apr 7, 2022
45c7a3c
Fix lint error
Mamaduka Apr 7, 2022
a773c8b
Don't break filters (almost)
Mamaduka Apr 15, 2022
bf9bada
Restore all filter props
Mamaduka Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Restore all filter props
  • Loading branch information
@Mamaduka
Mamaduka committed Apr 28, 2022
commit bf9badab8c1d7ba0f7f357469c2463f1f33cf5ab
43 changes: 30 additions & 13 deletions packages/editor/src/components/post-featured-image/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function PostFeaturedImage( {
currentPostId
);

function onDropImage( filesList ) {
function onDropFiles( filesList ) {
mediaUpload( {
allowedTypes: [ 'image' ],
filesList,
Expand Down Expand Up @@ -204,7 +204,7 @@ function PostFeaturedImage( {
( postLabel.set_featured_image ||
DEFAULT_SET_FEATURE_IMAGE_LABEL ) }
</Button>
<DropZone onFilesDrop={ onDropImage } />
<DropZone onFilesDrop={ onDropFiles } />
</div>
) }
value={ featuredImageId }
Expand Down Expand Up @@ -262,17 +262,34 @@ const applyWithSelect = withSelect( ( select ) => {
};
} );

const applyWithDispatch = withDispatch( ( dispatch ) => {
const { editPost } = dispatch( editorStore );
return {
onUpdateImage( image ) {
editPost( { featured_media: image?.id } );
},
onRemoveImage() {
editPost( { featured_media: 0 } );
},
};
} );
const applyWithDispatch = withDispatch(
( dispatch, { noticeOperations }, { select } ) => {
const { editPost } = dispatch( editorStore );
return {
onUpdateImage( image ) {
editPost( { featured_media: image.id } );
},
onDropImage( filesList ) {
select( blockEditorStore )
.getSettings()
.mediaUpload( {
allowedTypes: [ 'image' ],
filesList,
onFileChange( [ image ] ) {
editPost( { featured_media: image.id } );
},
onError( message ) {
noticeOperations.removeAllNotices();
noticeOperations.createErrorNotice( message );
},
} );
},
onRemoveImage() {
editPost( { featured_media: 0 } );
},
};
}
);

export default compose(
withNotices,
Expand Down