Skip to content

[RNMobile] - Update Paragraph tests to work locally and in CI on both platforms #40130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jostnes wants to merge 21 commits into from
Closed

[RNMobile] - Update Paragraph tests to work locally and in CI on both platforms #40130

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5e9fcbc
move test data and create optional wait for getBlockAtPosition
jostnes Apr 6, 2022
1d53176
lint fix extra space
jostnes Apr 6, 2022
1d0ca99
paragraph test fixes
jostnes Apr 7, 2022
9e5217b
remove locators from condition, use existing function instead of new
jostnes Apr 11, 2022
9943423
lint fix
jostnes Apr 11, 2022
3ac6213
move locator definition back to if condition
jostnes Apr 11, 2022
9f4c96a
lint fix
jostnes Apr 11, 2022
4e3926a
re-add condition android only
jostnes Apr 11, 2022
3d1f649
lint fix
jostnes Apr 11, 2022
f69290c
revert waitForVisible on removeBlock to not fail lists test
jostnes Apr 11, 2022
bee6a60
update hasBlockAtPosition to not use waits yet
jostnes Apr 11, 2022
b3590a7
lint fix
jostnes Apr 11, 2022
7d698b7
create another condition for type text to not mess other tests
jostnes Apr 12, 2022
38bd986
lint fix
jostnes Apr 12, 2022
061b26d
add list block
jostnes Apr 12, 2022
131dcce
set default switch values
jostnes Apr 12, 2022
4c26192
exclude untested blocks
jostnes Apr 12, 2022
7c447fc
lint fix
jostnes Apr 12, 2022
105f2a8
fix tests that use paragraphs instead of making conditions to fix jus…
jostnes Apr 13, 2022
710c76f
add wait to separator block test
jostnes Apr 13, 2022
f55c6c4
remove waits on non text blocks to be handled separately
jostnes Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fix
  • Loading branch information
@jostnes
jostnes committed Apr 11, 2022
commit 994342367a6c7953761c3d99556202a47f813e90
2 changes: 1 addition & 1 deletion packages/react-native-editor/__device-tests__/pages/editor-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class EditorPage {
// potentially can be removed when we have gone through all test cases
default:
elementTypeAndroid = '*';
elementTypeiOS = '*'
elementTypeiOS = '*';
textViewElementNameAndroid = '';
textViewElementNameiOS = '';
break;
Expand Down