Split navigation block view script #40135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: -2.44 kB (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
gziolo
added
[Package] Block library
Member
|
This PR needs rebasing and it’ll be ready to go 😃 |
aristath
force-pushed
the
add/nav-block-multiple-scripts
branch
from
19f54a0 to
ea42697
Compare
Member
Author
|
Thanks @gziolo! Rebased. 👍 |
gziolo
approved these changes
Apr 14, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
We reviewed it earlier before it was split to its PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR contains changes to the navigation block's
viewScript. These were initially a part of #36176, but it was decided to split them to a separate PR for clarity and separation of concerns.Why?
In the navigation block, we only need the modals script if the user has chosen to use modals. In this PR, we're splitting the modals script to a new file, and conditionally load this separate file if it is required.
This improves client-side performance by only loading the things that are needed, and reduces the amount of transferred bytes.
How?
Uses the implementation from #36176 to allow loading the scripts when needed.
Testing Instructions