Allow using a custom domainpath for viewscripts #40136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
aristath
force-pushed
the
fix/viewScript-custom-domainpath
branch
from
6333db8 to
f1df51b
Compare
Member
Author
|
Rebased the PR and resolved conflicts now that #36176 has been merged. 👍 |
gziolo
approved these changes
Apr 14, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Code looks great 👍
We should improve the documentation. Do we have unit tests covering this new API?
lib/compat/wordpress-6.0/blocks.php
Outdated
| 'in_footer' => false, | ||
|
|
||
| // Additional arg to allow translations for the script's textdomain. | ||
| // Additional args to allow translations for the script's textdomain. |
Member
There was a problem hiding this comment.
It feels like we should update the function’s documentation to make it more clear what every param should look like.
aristath
force-pushed
the
fix/viewScript-custom-domainpath
branch
from
f1df51b to
dbc0ab2
Compare
gziolo
added
the
[Feature] Block API
priethor
added
[Type] Enhancement
37 tasks
bph
added
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow using a custom
domainpathfor translations in view-scripts.Why?
See discussion in #36176 (comment)
How?
Adds a new
domainpatharg. Thedomainpathname was chooses for consistency with the Core patches on trac.