[Mobile] - KeyboardAvoidingView - Set a background color for the toolbar container #40266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
geriux
added
Mobile App - Automation
SiobhyB
approved these changes
Apr 13, 2022
Contributor
SiobhyB
left a comment
SiobhyB
left a comment
There was a problem hiding this comment.
I tested this in an iPad Pro (9.7 inch) simulator and confirmed it works well in both light and dark modes. It looks so much better with the background :D I also verified that I couldn't see any regressions with an iPhone or on Android. 🚢 🚀
geriux
removed
the
Mobile App - Automation
SiobhyB
pushed a commit
that referenced
this pull request
Apr 26, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#4370
Gutenberg Mobile PR-> [Mobile] - KeyboardAvoidingView - Set a background color for the toolbar container wordpress-mobile/gutenberg-mobile#4749What?
It sets a background color for the toolbar container within the
KeyboardAvoidingViewon iOS.Why?
On iPad devices when there's an external keyboard being used, a gap between the toolbar and the bottom of the screen is visible.
How?
By setting a background color to the toolbar container, this way when there's an external keyboard is being used, it won't look like the UI is broken.
Testing Instructions
Screenshots or screencast