Skip to content

Add settings hook #40547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 6 commits into from
Apr 29, 2022
+143 −23
Merged

Add settings hook #40547

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a194105
Add settings attribute via hook
oandregal Mar 8, 2022
6f75839
useSetting: take the setting from the block instance
oandregal Mar 8, 2022
05f266c
Test: enable settings for the group block
oandregal Mar 8, 2022
322e113
Update packages/block-editor/src/hooks/settings.js
oandregal Apr 25, 2022
f52967d
Add support for hierarchical block instance look up
oandregal Apr 25, 2022
c1a2762
Rename settings support to __experimentalSettings
oandregal Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test: enable settings for the group block
  • Loading branch information
@oandregal
oandregal committed Apr 28, 2022
commit 05f266c8cc225ba9f0db62a3146d847934b1e8a4
1 change: 1 addition & 0 deletions packages/block-library/src/group/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
}
},
"supports": {
"settings": true,
Copy link
Member Author

@oandregal oandregal Apr 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style attribute we already enable by the other block suports (color, typography, etc). Although unlikely, I wonder if there's a block that doesn't want the styles but does want the settings. This is why I used settings for the hook name instead of section.

If we want to go with section instead, I'd argue that we'd also want to make it register styles if they are not defined yet.

Copy link
Contributor

@mcsf mcsf Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real formed opinion on my part yet, but simply settings could make sense.

Copy link
Contributor

@youknowriad youknowriad Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "section" shouldn't be a thing in our code base, it should be a consequence of several enabled features/context. So I think "settings" is the right call. The only thing is whether we start stable or give it some time as "experimental".

Copy link
Member

@jorgefilipecosta jorgefilipecosta Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would lean to making it experimental for some time.

"align": [ "wide", "full" ],
"anchor": true,
"html": false,
Expand Down