[RNMobile] Set "expanded" version of inserter's "add blocks" text to title case #40550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
SiobhyB
added
Mobile App - i.e. Android or iOS
SiobhyB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gutenberg-mobile:[RNMobile] Set "expanded" version of inserter's "add blocks" text to title case wordpress-mobile/gutenberg-mobile#4787What?
With this PR, the
Add blockstext in the "expanded" version of the editor's inserter button (introduced in #39726) is set to title case via CSS.Why?
Previous to this PR, the
Add Blockstext in the button was set to title case (to match the button's design) simply by typing it in as title case within the code. This brought up two problems:Add blockswithin the app.Add blocksstring is already present and its translations can be re-used.How?
Add blockshas been set to "regular" sentence capitalisation in the code, in order to prevent extra strings from being added to translation files. In order to match the button's designs,text-transform: capitalize;has been used to transform the text to title case via CSS.Testing Instructions
Functionality
+inserter in the editor's toolbar when opening a new post. Verify that the text in this expanded button is capitalised asAdd Blocksrather thanAdd blocks.Translation Files
Add blocksstring in the translation files (with no variations with different capitalisation) in the bundle produced in the Gutenberg Mobile PR.Screenshots or screencast