Turn off WP 6.0 stopgap handler to use Webfonts API. #40555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellofromtonya
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
7 tasks
gziolo
approved these changes
Apr 26, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Looks great. I moved it to 6.0 then back to experimental. It was correctly placed as it needs to be colocated with the code that adds the full Webfonts API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40472.
What?
Turns off WordPress 6.0's
theme.jsonwebfonts handler (the stopgap implementation).Why?
To allow the Webfonts API in Gutenberg to run instead.
Notes
The mechanism to turn it off is dependent upon WordPress/wordpress-develop#2622 being committed into WordPress Core
trunk.