Skip to content

Render presets coming from the settings of a section #40683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oandregal wants to merge 6 commits into from
Closed

Render presets coming from the settings of a section #40683

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a194105
Add settings attribute via hook
oandregal Mar 8, 2022
6f75839
useSetting: take the setting from the block instance
oandregal Mar 8, 2022
05f266c
Test: enable settings for the group block
oandregal Mar 8, 2022
322e113
Update packages/block-editor/src/hooks/settings.js
oandregal Apr 25, 2022
f52967d
Add support for hierarchical block instance look up
oandregal Apr 25, 2022
3b6701a
Bootstrap code for rendering settings from a section
oandregal Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/block-editor/src/hooks/settings.js 
Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
  • Loading branch information
@oandregal @mcsf
oandregal and mcsf committed Apr 28, 2022
commit 322e113476b107d13a8b1801830d0bd836a5e50f
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { addFilter } from '@wordpress/hooks';
import { hasBlockSupport } from '@wordpress/blocks';

const hasSettingsSupport = ( blockType ) =>
hasBlockSupport( blockType, 'settings', true );
hasBlockSupport( blockType, 'settings', false );

function addAttribute( settings ) {
if ( ! hasSettingsSupport( settings ) ) {
Expand Down