Preferences: Improve initial configuration for the new persistence package #40715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Preferences
gziolo
force-pushed
the
update/preferences-persistence-polish
branch
from
0f91196 to
4a6845c
Compare
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
talldan
approved these changes
Apr 29, 2022
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Thanks - sorry I keep on messing this up!
Contributor
|
@gziolo Do we need some dev notes for this new package? For now, it doesn't seem to provide filters or hooks for extenders to work with it. (just added the label, to revisit) |
bph
added
the
Needs Dev Note
Contributor
talldan
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up for #39795 that introduced
@wordpress/preferences-persistence.Some minor changes to the package before it's initial npm publishing.
Why?
To ensure that the package is going to be released as
v1.0.0rather thanv1.1.0after automatic version bumps get applied.How?
I followed the documentation at https://github.com/WordPress/gutenberg/tree/trunk/packages#creating-a-new-package.
Testing Instructions
I executed
npm run buildto validate whether TS types are generated before removingtypesreference.Screenshots or screencast