Update to Jest v22.0.1 #4073
Merged
Update to Jest v22.0.1 #4073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
reviewed
Dec 19, 2017
| onClick={[Function]} | ||
| onFocus={[Function]} | ||
| onKeyDown={[Function]} | ||
| onClick={[MockFunction]} |
Member
There was a problem hiding this comment.
@sirreal You might like it, it is possible as of Jest 22.x to provide your own name to the mock, too. See: https://facebook.github.io/jest/blog/2017/12/18/jest-22.html#mock-function-improvements.
gziolo
approved these changes
Dec 19, 2017
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
That was fast 💯
Diff for package-lock.json seems a bit big, but it looks reasonable.
Member
Author
@gziolo It looked reasonable to me, I'm creating a new PR to recreate the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
• Upgrades Jest to v22.0.1 https://facebook.github.io/jest/blog/2017/12/18/jest-22.html
• Commit fcf70aa updates a single Jest snapshot per Jest v22 Mock function improvements #
How Has This Been Tested?
Ran
npm testScreenshots (jpeg or gifs if applicable):
Types of changes
Checklist: