Skip to content

Refactor the Popover component to use the floatingUI library #40740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 41 commits into from
May 18, 2022
Merged

Refactor the Popover component to use the floatingUI library #40740

Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
07cc373
Refactor the Popover component to use the floatingUI library
youknowriad Apr 29, 2022
e2fc1a7
Remove placement prop + small fixes
youknowriad May 4, 2022
0926333
Fix inbetween inserter position
youknowriad May 4, 2022
9d9e748
Some style tweaks
youknowriad May 4, 2022
6076815
Position the color popover properly
youknowriad May 4, 2022
4488e44
Simplify BlockAlignmentMatrixControl popover styles
youknowriad May 4, 2022
a534b64
Simplify block switcher popover CSS
youknowriad May 4, 2022
6705ae8
Better position for the Cover overlay color popover
youknowriad May 4, 2022
4bf13c0
More popover styles tweaks
youknowriad May 4, 2022
b17c576
hide popover when not within the same clipping context
ntsekouras May 4, 2022
7610e5c
Add the iframe offset middleware
youknowriad May 9, 2022
0638623
Revert hide middleware to fix inbetween inserter in site editor
youknowriad May 9, 2022
5180083
Add shift limit and support multi selections
youknowriad May 9, 2022
e342f8b
Remove flyout from manifest
youknowriad May 9, 2022
52ba2d7
Add back animation
youknowriad May 9, 2022
3354ad6
Fix popover unit test
youknowriad May 9, 2022
f3effa8
Fix support for range popovers
youknowriad May 9, 2022
695e11a
Restore default dropdown gutter
youknowriad May 10, 2022
8501d2f
Restore tooltip position
youknowriad May 10, 2022
2eceda7
Fix color palette position
youknowriad May 10, 2022
5166b37
Position the border-box-control popovers correctly
youknowriad May 10, 2022
6367d4d
Fix unit tests
youknowriad May 10, 2022
3e66b1f
Fix e2e test
youknowriad May 10, 2022
c11ff65
Fix animation origin
youknowriad May 10, 2022
b52b0c7
Deprecate range prop
youknowriad May 11, 2022
2fe712f
Update Popover README
youknowriad May 11, 2022
8a8fcea
Add comment to explain offset value
youknowriad May 11, 2022
38014cf
Change the type of popoverProps
youknowriad May 11, 2022
f0eebe0
Fix position shifting
youknowriad May 12, 2022
b7ce415
Remove extra div from popover
youknowriad May 12, 2022
4ba2005
Apply suggestions from code review (documentation)
youknowriad May 12, 2022
43c4ff9
documentation fix
youknowriad May 12, 2022
abad260
Fix correct classname for border control dropdown.
youknowriad May 12, 2022
7aff278
Better border box props documentation
youknowriad May 12, 2022
64e051d
Simplify border control popover styles
youknowriad May 12, 2022
d9ec0bb
Fix more menu size
youknowriad May 12, 2022
87fb541
Add the max size behavior
youknowriad May 12, 2022
8e433bb
Fix border control popover styles
youknowriad May 16, 2022
3a0c29a
Fix image zoom popover
youknowriad May 16, 2022
3caf4b4
Fix scroll shifts when focusing popovers
youknowriad May 16, 2022
662002c
fix custom color test
ntsekouras May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove flyout from manifest
  • Loading branch information
@youknowriad
youknowriad committed May 16, 2022
commit e342f8b1135e031879774b67e2c042b13f0a6cfd
6 changes: 0 additions & 6 deletions docs/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,12 +815,6 @@
"markdown_source": "../packages/components/src/flex/flex/README.md",
"parent": "components"
},
{
"title": "Flyout",
"slug": "flyout",
"markdown_source": "../packages/components/src/flyout/flyout/README.md",
"parent": "components"
},
{
"title": "FocalPointPicker",
"slug": "focal-point-picker",
Expand Down