Skip to content

Border Controls: Passthrough popover props instead of class names #40836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronrobertshaw wants to merge 10 commits into from
Closed

Border Controls: Passthrough popover props instead of class names #40836

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3504194
Move assignment of popover class name to popoverProps on Dropdown
aaronrobertshaw May 5, 2022
8d75e8e
Remove placeholder CSS class that was only there to satisfy TypeScript
aaronrobertshaw May 5, 2022
49d1f65
Switch border control dropdown to popoverProps
aaronrobertshaw May 5, 2022
a183d9d
Switch border control component to popoverProps
aaronrobertshaw May 5, 2022
cfdf0e8
Switch BorderBoxControl to popoversProps
aaronrobertshaw May 5, 2022
9c75458
Switch border support to use popoversProps
aaronrobertshaw May 5, 2022
0e67fce
Update border control readmes for new popoverProps prop
aaronrobertshaw May 5, 2022
d91b0ee
Add changelog
aaronrobertshaw May 5, 2022
8bd8737
Make ColorPalette className option by adding default as undefined
aaronrobertshaw May 5, 2022
cdf0cf1
Fix className typing error by moving prop destructuring
aaronrobertshaw May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Move assignment of popover class name to popoverProps on Dropdown
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed May 5, 2022
commit 3504194b49115370f392aafd3abdfe840f105e49
2 changes: 1 addition & 1 deletion packages/components/src/border-control/border-control-dropdown/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ const BorderControlDropdown = (
<Dropdown
renderToggle={ renderToggle }
renderContent={ renderContent }
contentClassName={ popoverClassName }
popoverProps={ { className: popoverClassName } }
{ ...otherProps }
ref={ forwardedRef }
/>
Expand Down