Merged
Conversation
ciampo
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
andrewserong
approved these changes
May 5, 2022
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for following up, the change looks good to me — more verbose, but also more explicit 👍
aaronrobertshaw
approved these changes
May 5, 2022
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for addressing this one @ciampo 👍
While it is more verbose, following the recommendations from the official docs sounds like a good idea.
- Unit tests are passing
- All tests requiring the setup have been updated
LGTM 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #40790
As pointed out in this comment, currently
@testing-library/user-eventis setup once per test file while the official docs recommend setting it up inline, once per test.Why?
Following the official docs to avoid unexpected/unreliable behavior in unit tests.
How?
Refactored
UnitControlandFormFileUploadunit tests so that theuserEvent.setup()call happens inline, once per test.Testing Instructions
Unit tests pass.