Skip to content

BorderControls: Alternate approach to handling popover positioning #40874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronrobertshaw wants to merge 5 commits into from
Closed

BorderControls: Alternate approach to handling popover positioning #40874

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3621019
Fix destructuring of ColorPalette to resolve typing error
aaronrobertshaw May 6, 2022
495b61d
Remove popover positioning CSS for border support
aaronrobertshaw May 6, 2022
a813973
Move handling of popover position/styling to BorderControl
aaronrobertshaw May 6, 2022
3aea82f
Update BorderBoxControl for new popover positioning and responsive st…
aaronrobertshaw May 6, 2022
5a62136
Add new props to story controls
aaronrobertshaw May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix destructuring of ColorPalette to resolve typing error
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed May 6, 2022
commit 362101992efc7195f498a6c9720ac8decb626c00
24 changes: 13 additions & 11 deletions packages/components/src/color-palette/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,17 +152,19 @@ const extractColorNameFromCurrentValue = (
return __( 'Custom' );
};

export default function ColorPalette( {
clearable = true,
className,
colors,
disableCustomColors = false,
enableAlpha,
onChange,
value,
__experimentalHasMultipleOrigins = false,
__experimentalIsRenderedInSidebar = false,
} ) {
export default function ColorPalette( props ) {
const {
clearable = true,
className,
colors,
disableCustomColors = false,
enableAlpha,
onChange,
value,
__experimentalHasMultipleOrigins = false,
__experimentalIsRenderedInSidebar = false,
} = props;

const clearColor = useCallback( () => onChange( undefined ), [ onChange ] );
const showMultiplePalettes =
__experimentalHasMultipleOrigins && colors?.length;
Expand Down