Skip to content

Editable: Enter splits the current paragraph into two blocks #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 11 commits into from
Apr 19, 2017
Merged

Editable: Enter splits the current paragraph into two blocks #409

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
18e5a72
Editable: Enter splits the current paragraph into two blocks
youknowriad Apr 12, 2017
07e6edf
Split text block on double enter
youknowriad Apr 13, 2017
50f49b4
Avoid defaultProps
youknowriad Apr 17, 2017
9a23d20
Original test strings
youknowriad Apr 17, 2017
0dc010b
Using the create block helper
youknowriad Apr 17, 2017
706fbc5
Fix the paragraph styling
youknowriad Apr 17, 2017
75a0f0d
Dropping unused dependency uuid
youknowriad Apr 17, 2017
49a169e
Fix splitting behaviour when we have some formatting
youknowriad Apr 17, 2017
de3265a
- No div wrapper for text block
youknowriad Apr 18, 2017
fbdec2b
Using newBlock event instead of using setTimeout
youknowriad Apr 18, 2017
ee12b37
Adding a comment about the temporary wrapper
youknowriad Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid defaultProps
  • Loading branch information
@youknowriad
youknowriad committed Apr 18, 2017
commit 50f49b448e56de862eab0235860f0e93873dc2a9
6 changes: 1 addition & 5 deletions blocks/components/editable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class Editable extends wp.element.Component {
}

onKeyDown( event ) {
if ( this.props.tagName || event.keyCode !== 13 ) {
if ( this.props.tagName || event.keyCode !== 13 || ! this.props.onSplit ) {
return;
}

Expand Down Expand Up @@ -136,7 +136,3 @@ export default class Editable extends wp.element.Component {
);
}
}

Editable.defaultProps = {
onSplit: () => {}
};