Skip to content

List View: Add right-click behaviour to open block settings dropdown, and add right click overrides editor setting #41041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 7 commits into from
Closed

List View: Add right-click behaviour to open block settings dropdown, and add right click overrides editor setting #41041

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
097564f
List View: Add right-click onContextMenu callback to open block setti…
andrewserong May 13, 2022
253bdeb
Add edit-post and edit-site option to disable overriding default righ…
andrewserong May 13, 2022
6e3198c
Update snapshot
andrewserong May 13, 2022
7b45809
Move allowRightClickOverrides to an editor setting instead of a stabl…
andrewserong May 13, 2022
cd8d58f
Remove unneeded whitespace change
andrewserong May 13, 2022
d2bc061
Update getSettings test
andrewserong May 13, 2022
3b48415
Try anchoring the position of the settings dropdown to the right clic…
andrewserong May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update snapshot
  • Loading branch information
@andrewserong
andrewserong committed May 27, 2022
commit 6e3198c598be1d92d29970e10e77cb5552669bd9
10 changes: 10 additions & 0 deletions packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active
help="Shows block breadcrumbs at the bottom of the editor."
label="Display block breadcrumbs"
/>
<WithSelect(WithDispatch(BaseOption))
featureName="allowRightClickOverrides"
help="Allows contextual menus via right-click, overriding browser defaults."
label="Allow right-click contextual menus"
/>
</Section>
</React.Fragment>,
"name": "general",
Expand Down Expand Up @@ -183,6 +188,11 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active
help="Shows block breadcrumbs at the bottom of the editor."
label="Display block breadcrumbs"
/>
<WithSelect(WithDispatch(BaseOption))
featureName="allowRightClickOverrides"
help="Allows contextual menus via right-click, overriding browser defaults."
label="Allow right-click contextual menus"
/>
</Section>
</React.Fragment>,
"name": "general",
Expand Down