Skip to content

[Mobile] - Fix Drag & Drop Chip positioning issue with RTL languages #41053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 3 commits into from
May 18, 2022
Merged

[Mobile] - Fix Drag & Drop Chip positioning issue with RTL languages #41053

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90377c0
Mobile - Fix - Drag & drop chip issue with RTL languages
May 13, 2022
a6e9016
Mobile - BlockDraggable - Rename maxWidth variable to contentWidth
May 17, 2022
95a1bdf
Mobile - BlockDraggable - Add custom exiting animation that uses the …
May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mobile - BlockDraggable - Rename maxWidth variable to contentWidth
  • Loading branch information
Gerardo committed May 17, 2022
commit a6e90162cb7aa9f9bb2cd7714a66c2824d86d123
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/block-draggable/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const BlockDraggableWrapper = ( { children, isRTL } ) => {
const { left, right } = useSafeAreaInsets();
const { width } = useSafeAreaFrame();
const safeAreaOffset = left + right;
const maxWidth = width - safeAreaOffset;
const contentWidth = width - safeAreaOffset;
animatedScrollRef( scrollRef );

const scroll = {
Expand Down Expand Up @@ -210,7 +210,7 @@ const BlockDraggableWrapper = ( { children, isRTL } ) => {
const chipOffset = chip.width.value / 2;
const translateX = ! isRTL
? chip.x.value - chipOffset
: -( maxWidth - ( chip.x.value + chipOffset ) );
: -( contentWidth - ( chip.x.value + chipOffset ) );

return {
transform: [
Expand Down