Testing: refactor check-local-changes script #41074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Type] Automated Testing
t-hamano
changed the title
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
Mamaduka
added
[Type] Build Tooling
gziolo
approved these changes
May 27, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Everything works as expected in my testing on macOS 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39388
What?
This PR refactors the
check-local-changesscript into a node.js-based process rather than an OS-dependent command.Why?
In the previous process,
git diffresults were passed toxargsand processed directly on the npm script.However, xargs is not recognized by Windows and other operating systems, causing errors such as the following:
With this PR, the command can be executed correctly on Windows OS.
(although there may be no need to run it locally...)
How?
I use the
simple-gitpackage and refactored it to do the same in a single js file.I am not familiar with writing npm scripts, so please point out anything inappropriate.
Testing Instructions
Case 1
npm run check-local-changes.precheck-local-changes.Case 2
"optional": trueto one of the packages inpackage-lock.json.npm run check-local-changes.package-lock.jsonhas been changed.(see: Testing: Fail CI build if local changes exist #10234)
Case 3
npm run check-local-changes.