Skip to content

[Mobile] - BlockList - Add internal onLayout from CellRendererComponent to BlockListItemCell #41105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 2 commits into from
May 18, 2022
Merged

[Mobile] - BlockList - Add internal onLayout from CellRendererComponent to BlockListItemCell #41105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
140b3f1
Mobile - BlockList - Pass FlatList internal onLayout through CellRend…
May 17, 2022
f68a4b7
Mobile - Update onLayout naming for BlockListItemCell
May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mobile - Update onLayout naming for BlockListItemCell
  • Loading branch information
Gerardo committed May 17, 2022
commit f68a4b707b6af4e8ce60cce06465071fb41228cd
17 changes: 6 additions & 11 deletions packages/block-editor/src/components/block-list/block-list-item-cell.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,7 @@ import { useEffect, useCallback } from '@wordpress/element';
*/
import { useBlockListContext } from './block-list-context';

function BlockListItemCell( {
children,
clientId,
rootClientId,
listOnLayout,
} ) {
function BlockListItemCell( { children, clientId, rootClientId, onLayout } ) {
const { blocksLayouts, updateBlocksLayouts } = useBlockListContext();

useEffect( () => {
Expand All @@ -30,7 +25,7 @@ function BlockListItemCell( {
};
}, [] );

const onLayout = useCallback(
const onCellLayout = useCallback(
( event ) => {
const {
nativeEvent: { layout },
Expand All @@ -41,14 +36,14 @@ function BlockListItemCell( {
...layout,
} );

if ( listOnLayout ) {
listOnLayout( event );
if ( onLayout ) {
onLayout( event );
}
},
[ clientId, rootClientId, updateBlocksLayouts, listOnLayout ]
[ clientId, rootClientId, updateBlocksLayouts, onLayout ]
);

return <View onLayout={ onLayout }>{ children }</View>;
return <View onLayout={ onCellLayout }>{ children }</View>;
}

export default BlockListItemCell;
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-list/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export class BlockList extends Component {
<BlockListItemCell
children={ children }
clientId={ item }
listOnLayout={ onLayout }
onLayout={ onLayout }
rootClientId={ rootClientId }
/>
);
Expand Down