Skip to content

Add waitForVisible() to all blocks #41126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jostnes merged 14 commits into from
May 25, 2022
Merged

Add waitForVisible() to all blocks #41126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bf096d
add waits to all block - 1st try
jostnes May 18, 2022
85bfebf
fix failing tests
jostnes May 18, 2022
db54e18
correct if else condition
jostnes May 19, 2022
4432298
fix failing cover block test
jostnes May 19, 2022
08435cb
update spaces
jostnes May 19, 2022
65f3c62
update to use new click helper
jostnes May 19, 2022
1a00cd1
wait for blocks to be visible first in getFirstBlock and getLastBlock
jostnes May 19, 2022
a5ba829
remove length as a parameter
jostnes May 19, 2022
9dc1b8f
update timing for long press since it's failing intermittently in ci
jostnes May 20, 2022
dd7aa72
remove deleted param, revert space changes
jostnes May 20, 2022
0b2c965
remove redundant code
jostnes May 20, 2022
46798af
exit function once condition is met
jostnes May 20, 2022
36adacd
increse wait time for long press
jostnes May 23, 2022
86a5d30
remove unneccesary condition, update message, return click value
jostnes May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update timing for long press since it's failing intermittently in ci
  • Loading branch information
@jostnes
jostnes committed May 20, 2022
commit 9dc1b8f382ded235400087efd888f6c1ccd7c014
3 changes: 2 additions & 1 deletion packages/react-native-editor/__device-tests__/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ const longPressMiddleOfElement = async ( driver, element ) => {
const x = location.x + size.width / 2;
const y = location.y + size.height / 2;
action.press( { x, y } );
action.wait( 2000 );
// Setting to wait a bit longer because this is failing more frequently on the CI
action.wait( 3500 );
Copy link
Contributor Author

@jostnes jostnes May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the wait here before releasing the button press as found out that this is the culprit for flakiness on the gutenberg-editor-block-insertion-2.test.js tests.

Some examples of this failing before the fix from the past week: 1, 2, 3.

This is how the test should look like when the wait time is enough and the correct element is pressed at the right time.

action.release();
await action.perform();
};
Expand Down
6 changes: 1 addition & 5 deletions packages/react-native-editor/__device-tests__/pages/editor-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,7 @@ class EditorPage {
? '//android.widget.Button[@content-desc="Add Block Before"]'
: '//XCUIElementTypeButton[@name="Add Block Before"]';

const addBlockBeforeButton = await waitForVisible(
this.driver,
addBlockBeforeButtonLocator
);
await addBlockBeforeButton.click();
await clickIfClickable( this.driver, addBlockBeforeButtonLocator );
} else {
await addButton.click();
}
Expand Down