Components: refactor AlignmentMatrixControl to pass exhaustive-deps
#41167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
|
Size Change: +6 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
May 20, 2022
…. Update dependency array
chad1008
force-pushed
the
enhance/AlignmentMatrixControl-exhaustive-deps
branch
from
5f94dcf to
e872e6b
Compare
ciampo
reviewed
May 23, 2022
ciampo
reviewed
May 23, 2022
ciampo
reviewed
May 23, 2022
ciampo
approved these changes
May 23, 2022
westonruter
added a commit
that referenced
this pull request
May 23, 2022
…p-tests-config * 'trunk' of github.com:WordPress/gutenberg: (88 commits) Components: refactor `AlignmentMatrixControl` to pass `exhaustive-deps` (#41167) [RNMobile] Add 'Insert from URL' option to Image block (#40334) [RNMobile] Improvements to Getting Started Guides (#40964) Post Author Name: Add to and from Post Author transformations (#41151) CheckboxControl: Add unit tests (#41165) Improve inline documentation (#41209) Mobile Release v1.76.1 (#41196) Use explicit type definitions for entity configuration (#40995) Scripts: Convert file extension to js in `block.json` during build (#41068) Reflects revert in 6446878 (#41221) get_style_nodes should be compatible with parent method. (#41217) Gallery: Opt-in to axial (column/row) block spacing controls (#41175) Table of Contents block: convert line breaks to spaces in headings. (#41206) Add support for button elements to theme.json (#40260) Global Styles: Load block CSS conditionally (#41160) Update URL (#41188) Improve autocompleter performance (#41197) Site Editor: Set min-width for styles preview (#41198) Remove Navigation Editor screen from experiments page (#40878) Fix broken Page title for pages created inline within in Nav block (#41063) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
AlignmentMatrixControlcomponent to satisfy theexhaustive-depseslint ruleWhy?
Part of the effort in #41166 to apply
exhuastive-depsto the Components packageHow?
baseIdto theuseEffectdependency arraycomposite.setCurrentId(...)within the effect makescompositeitself a dependency, because it gets called as thethisvalue tosetCurrentId. Addingcompositedirectly to the dependency array triggers a loop. Destructuringcomposite.setCurrentIdinto its own variable before the effect allows us to rely on just that individual value in our dependency array, eliminate the loop while satisfying the linter.Testing Instructions
exhaustive-depseslint rule #41166, OR manually set'react-hooks/exhaustive-deps': 'warn'in your local eslint filenpx eslint packages/components/src/alignment-matrix-control