Skip to content

Rewrite <FormTokenField> to functional component and Typescript. #41216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torounit merged 34 commits into from
Jun 2, 2022
Merged

Rewrite <FormTokenField> to functional component and Typescript. #41216

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
17ab8c8
refactor `<TokenInput>` to functional component and Typescript.
torounit May 21, 2022
5dc6be3
use findRenderedDOMComponentWithTag instead of findRenderedComponentW…
torounit May 21, 2022
6f6553b
convert `<Token>` to TypeScript
torounit May 21, 2022
eeaf143
type only import
torounit May 21, 2022
513e8fa
convert SuggestionsList to TypeScript
torounit May 21, 2022
5911062
Change to not use withSafeTimeout. ref: https://github.com/WordPress/…
torounit May 21, 2022
5f21e05
Remove comment because tabIndex is not specified.
torounit May 21, 2022
d6ea243
add type for dom-scroll-into-view
torounit May 22, 2022
56c9516
add form-token-field dir to include in tsconfig.json
torounit May 22, 2022
759cd45
refactoring types.
torounit May 22, 2022
1875998
fix type.
torounit May 22, 2022
d8cb6c2
refactor FormTokenField to TypeScript and Functional Component
torounit May 22, 2022
b790e13
refactor story
torounit May 22, 2022
545edd0
allow set suggestions in stories.
torounit May 22, 2022
78845d3
Use act where useEffect is relevant.
torounit May 22, 2022
2c3f570
separate state
torounit May 22, 2022
321a0e0
revert ts-nocheck
torounit May 22, 2022
6fa7624
remove onChange prop form storybook
torounit May 27, 2022
3912110
Update packages/components/src/form-token-field/token-input.tsx
torounit May 27, 2022
7d9dbbd
use ComponentProps
torounit May 27, 2022
54106cc
add type docs
torounit May 27, 2022
1f28d51
replace token-field-wrapper to tsx
torounit May 27, 2022
29f0a9a
add doc comment for FormTokenField
torounit May 27, 2022
5da1391
fix type docs
torounit May 27, 2022
ad0a191
Update packages/components/src/form-token-field/types.ts
torounit May 30, 2022
5bf7dd3
Update packages/components/src/form-token-field/types.ts
torounit May 30, 2022
f716d31
Update packages/components/src/form-token-field/index.tsx
torounit May 30, 2022
3e72c70
Update packages/components/src/form-token-field/index.tsx
torounit May 30, 2022
5d16757
Update packages/components/src/form-token-field/index.tsx
torounit May 30, 2022
a80a192
change variable and function name
torounit Jun 1, 2022
03420cc
Fix useEffect to updateSuggestions().
torounit Jun 1, 2022
e1bc853
Disabled control for __experimentalValidateInput. Update type document.
torounit Jun 1, 2022
98d5fbc
add changelog
torounit Jun 2, 2022
5039721
Update packages/components/src/form-token-field/index.tsx
torounit Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/components/src/form-token-field/types.ts 
Co-authored-by: Lena Morita <lena@jaguchi.com>
  • Loading branch information
@torounit @mirka
torounit and mirka committed Jun 2, 2022
commit ad0a191a3c0c92500108914d994760a690e0c8da
2 changes: 2 additions & 0 deletions packages/components/src/form-token-field/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ export interface FormTokenFieldProps
suggestions?: string[];
/**
* The maximum number of suggestions to display at a time.
*
* @default 100
*/
maxSuggestions?: number;
/**
Expand Down