Skip to content

Entity-aware type signature for getEntityRecord and getEntityRecords #41235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamziel merged 9 commits into from
Jun 4, 2022
Merged

Entity-aware type signature for getEntityRecord and getEntityRecords #41235

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
78c8bce
Exhaustive type for getEntityRecord
adamziel May 23, 2022
d2d830e
Type signatures for getEntityRecord and getEntityRecords
adamziel May 26, 2022
80fb582
Inline the implementation of getEntityRecordImplementation
adamziel May 26, 2022
dce5397
Explain the need for typed-rememo.ts
adamziel May 26, 2022
fc343d4
Remove typed-rememo.ts
adamziel Jun 2, 2022
eb36773
Use correct type inference for Context in getEntityRecords by removin…
adamziel Jun 2, 2022
40c330e
Remove as any with as Kind[] and as Name[]
adamziel Jun 2, 2022
a96e711
Clean up imports
adamziel Jun 2, 2022
5d81376
Remove dev artifacts
adamziel Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up imports
  • Loading branch information
@adamziel
adamziel committed Jun 2, 2022
commit a96e71109938f441ab6c33fa5d143a53640d7283
7 changes: 4 additions & 3 deletions packages/core-data/src/selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,18 @@ import { STORE_NAME } from './name';
import { getQueriedItems } from './queried-data';
import { DEFAULT_ENTITY_KEY } from './entities';
import { getNormalizedCommaSeparable, isRawAttribute } from './utils';
import type { Context, User, WpTemplate } from './entity-types';
import {
import type {
Context,
DefaultContextOf,
EntityRecordOf,
KeyOf,
Kind,
KindOf,
Name,
NameOf,
User,
WpTemplate,
} from './entity-types';
import type { OmitNevers } from './entity-types/helpers';

// This is an incomplete, high-level approximation of the State type.
// It makes the selectors slightly more safe, but is intended to evolve
Expand Down