Skip to content

Tooltip: Fix positioning by anchoring to child element #41268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 17 commits into from
Jul 19, 2022
Merged

Tooltip: Fix positioning by anchoring to child element #41268

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
feb14f2
ToolTip: Fix positioning by anchoring to child element
andrewserong May 24, 2022
7e7715c
Fix left/right issue
andrewserong May 24, 2022
a52ee64
Switch post schedule and post visiblity to 'bottom right' for consist…
andrewserong May 24, 2022
a546fda
Move left/right transformation to the ToolTip component
andrewserong May 24, 2022
c700826
Switch back to functions, fix tests
andrewserong May 24, 2022
ec06c72
Tidy up
andrewserong May 24, 2022
a57bc9d
Add changelog entry
andrewserong May 24, 2022
338b2aa
Center Tooltip to the appropriate placement point
andrewserong May 25, 2022
c09a8b2
Attempt to simplify the implementation
andrewserong Jul 11, 2022
a0ba72d
Revert change to test
andrewserong Jul 11, 2022
6fc7d73
Revert default back to middle position
andrewserong Jul 12, 2022
5131ea8
Fix error with getDisabledElement
andrewserong Jul 12, 2022
b903d19
Move ref in disabled element to the cloned child element
andrewserong Jul 13, 2022
4f67e5b
Update Storybook example with a small target to better demonstrate po…
andrewserong Jul 13, 2022
9454226
Simplify Tooltip story slightly
andrewserong Jul 13, 2022
90f5541
Consolidate child const for both uses
andrewserong Jul 14, 2022
88f9e6c
Revert previous change, but add a named const for the existing child …
andrewserong Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix error with getDisabledElement
  • Loading branch information
@andrewserong
andrewserong committed Jul 13, 2022
commit 5131ea80f76e1ee569b3200aa1f0f107946ff71b
5 changes: 2 additions & 3 deletions packages/components/src/tooltip/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const getDisabledElement = ( {
eventHandlers,
child,
childrenWithPopover,
anchorRef,
mergedRefs,
} ) => {
return cloneElement(
<span className="disabled-element-wrapper">
Expand All @@ -45,7 +45,7 @@ const getDisabledElement = ( {
children: childrenWithPopover,
} ) }
</span>,
{ ...eventHandlers, ref: anchorRef }
{ ...eventHandlers, ref: mergedRefs }
);
};

Expand Down Expand Up @@ -256,7 +256,6 @@ function Tooltip( props ) {
child,
eventHandlers,
childrenWithPopover,
anchorRef: childRef,
mergedRefs: mergedChildRefs,
} );
}
Expand Down