Allow removing bottom margin from SelectControl#41269
Merged
noisysocks merged 2 commits intotrunkfrom May 24, 2022
Merged
Conversation
49 tasks
Contributor
|
Added the Needs Dev Note label in case this needs a dev note for the 6.1 release. |
Member
|
We'll be officially deprecating the margins as a separate PR (centrally managed in #38730), at which time we'll post the Dev Note. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What?
Allows removing the bottom margin from
SelectControlby specifying a__nextHasNoMarginBottomprop.Why?
@wordpress/componentsis slowly transitioning away from this.SelectControlin Design updates to the Publish popover (DateTimePicker) #41097.How?
BaseControlalready has a__nextHasNoMarginBottomprop so the approach here is to just use that fromSelectControl.I am not adding a call to
deprecate()as there are dozens of uses ofSelectControlin Gutenberg that need to be adjusted first. This is also the approach that was taken withBaseControl.Testing Instructions
npm run storybook:devSelectControlcomponent.__nextHasNoMarginBottomremoves the bottom margin from the control's wrapper.